Merged
Conversation
Signed-off-by: BoxBoxJason <contact@boxboxjason.dev>
There was a problem hiding this comment.
Pull request overview
This PR adds first-class support for SonarQube V2 Analysis endpoints in the Go SDK and applies a breaking rename that removes the V2 suffix from V2 service types where there’s no naming conflict.
Changes:
- Implement
AnalysisServicewith V2 endpoints for version, JRE metadata/download, scanner engine metadata/download, and active rules. - Rename multiple V2 service types to drop the
V2suffix and updateClientV2 service initialization accordingly. - Add unit tests and integration (e2e) tests covering the new Analysis V2 API behaviors.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| sonar/analysis_v2_service.go | Adds the V2 Analysis service implementation and related request/response types. |
| sonar/analysis_v2_service_test.go | Adds unit tests for all newly implemented Analysis V2 endpoints. |
| integration_testing/v2_analysis_test.go | Adds e2e coverage for Analysis V2 endpoints against a real SonarQube instance. |
| sonar/client.go | Updates ServicesV2 to use renamed V2 service types and initializes them. |
| sonar/users_v2_service.go | Renames the Users Management V2 service type to remove the V2 suffix. |
| sonar/marketplace_v2_service.go | Renames the Marketplace V2 service type to remove the V2 suffix. |
| sonar/dop_translation_v2_service.go | Renames the DOP Translation V2 service type to remove the V2 suffix. |
| sonar/clean_code_policy_v2_service.go | Renames the Clean Code Policy V2 service type to remove the V2 suffix. |
| sonar/authorizations_v2_service.go | Renames the Authorizations V2 service type to remove the V2 suffix. |
You can also share your feedback on Copilot code review. Take the survey.
Signed-off-by: BoxBoxJason <contact@boxboxjason.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR adds the support of the new analysis v2 api endpoints
BREAKING CHANGE: rename every "V2" service to remove the "V2" suffix when non duplicate
Closes #181
I have:
How has this code been tested
I have
make lintpasses to verify that the code style is correct.make testpasses to verify that the code is working as intended.make e2epasses to verify that end-to-end tests pass against a real SonarQube instance.