Merged
Conversation
Signed-off-by: BoxBoxJason <contact@boxboxjason.dev>
There was a problem hiding this comment.
Pull request overview
Adds SonarQube V2 Authorizations support to the Go SDK, implementing the missing REST endpoints for authorization groups and group memberships (issues #180, #179).
Changes:
- Implemented V2 Authorizations service methods for groups and group-memberships CRUD/search.
- Added unit tests for the new V2 Authorizations service.
- Added end-to-end (Ginkgo) integration tests covering the new V2 endpoints.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
sonar/authorizations_v2_service.go |
Introduces V2 Authorizations service, request/response models, and validation + methods for groups and memberships. |
sonar/authorizations_v2_service_test.go |
Adds unit tests for the new service methods and validations. |
integration_testing/v2_authorizations_test.go |
Adds e2e coverage for group + membership workflows against a real SonarQube instance. |
You can also share your feedback on Copilot code review. Take the survey.
Signed-off-by: BoxBoxJason <contact@boxboxjason.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR adds the support of the entire authorizations v2 API (all of its existing endpoints).
Closes #180
Closes #179
I have:
How has this code been tested
I have:
make lintpasses to verify that the code style is correct.make testpasses to verify that the code is working as intended.make e2epasses to verify that end-to-end tests pass against a real SonarQube instance.