Feat: Configurable Push Force#6
Open
Raiakos wants to merge 3 commits into
Open
Conversation
Owner
|
With the spirt of the mod in mind, I don't think this is how I would like to implement a configuration for push forces. Since this can easily be abused as it is, the push force should likely be dependent on the host player's config rather than an arbitrary value set by the client. That would involve some RPC syncing with the host and some detection for if the host client does not have the mod where the default value could be used instead. If that is done, I would merge this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the ability to configure the push force from the config menu. Left the default value as 500f.
P.S. This is my first time contributing to a Unity mod, and I didn't have all the dependencies installed, so I couldn't build and test on my end, but as it's a relatively simple commit, I'm hoping that you can test it and it will all work out. Feel free to reject if this is wrong, and let me know what I need to do better.