fix(ctf): scale event egress without per-range routers - #2381
Merged
Merged
Conversation
Owner
Author
|
Ground Control delivery — this pull request delivers issue #2372; Phase E runs on merge. |
# Conflicts: # shifter/engine/provisioner/gcp_range_cells.py
Merge the shared-NAT and missing-router_nat early exits into a single guard so _ensure_router_nat has three returns instead of four (Sonar S1142). Behavior is unchanged: a shared-NAT range still calls ensure_shared_nat and returns False, and a zero-egress range still returns False without creating a router.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CTF launches now pin the event workspace's egress policy without changing participant range ownership. Shared-VPC GCP ranges use serialized, explicitly scoped regional NAT capacity instead of a router per range.
Requirement UIDs
Related Issues
Closes #2372
ADR Impact
Changes
Test Plan
Targeted platform and GCP suites, import boundaries, Ruff, and ADR guard passed locally; hosted CI remains the delivery gate.
Ground Control Checks
Traceability
Checklist
Documentation
Updated: see diff.