Repository navigation
fix(smoke): include the provisioner's bounded diagnostic in the failure reason - #2493
Merged
Merged
Conversation
…re reason The range keeps only the closed reason code (for example cloud_operation_failed), which says nothing about what failed. The provisioner's authored, value-free diagnostic rides the latest terminal-failed operation result; append it so the smoke log names the failing step.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
#2488 made the smoke print the failed range's recorded reason, but the range keeps only the closed reason code. On aws-dev that printed
cloud_operation_failed, which does not say what failed.Change
The provisioner's authored, value-free diagnostic (bounded by
MAX_DIAGNOSTIC_CHARS) rides the latestraes_terminal_failedoperation result for the request.get_range_failure_reason_by_requestnow appends it, so the smoke log reads<reason_code>: <diagnostic>.Verification
tests/mission_control/test_run_post_deploy_smoke_command.pypasses; the failure-reason case seeds a real terminal-failed result row and asserts the code and diagnostic both reach the smoke error.