Repository navigation
fix(eks): forward the storage bucket to the provisioner Job - #2500
Merged
Merged
Conversation
The aws-dev smoke now fails with "RAES content delivery bucket is not configured": source-backed delivery reads RAES_CONTENT_DELIVERY_BUCKET, falling back to STORAGE_BUCKET_NAME, and the AWS provisioner Job received neither (only AGENT_S3_BUCKET / NGFW_BOOTSTRAP_BUCKET). The GCP provisioner already gets STORAGE_BUCKET_NAME. Forward STORAGE_BUCKET_NAME from the platform runtime env on AWS: add it to the installation forwarding contract (which engine.ecs imports), the AWS env allowlist of restrict-provisioner-jobs, and the published contract.
The bundle test pinned STORAGE_BUCKET_NAME's consumers to portal and worker; it is now intentionally forwarded to the provisioner Job for source-backed content delivery.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On aws-dev, source-backed RAES content delivery fails with:
The provisioner's delivery config reads
RAES_CONTENT_DELIVERY_BUCKET, falling back toSTORAGE_BUCKET_NAME. The AWS (EKS) provisioner Job receives neither: its forwarded contract has the storage bucket only asAGENT_S3_BUCKET/NGFW_BOOTSTRAP_BUCKET. The GCP provisioner already receivesSTORAGE_BUCKET_NAME.Change
Forward
STORAGE_BUCKET_NAME(already in the platform runtime env) to the AWS provisioner Job:installation/runtime_inventory_aws.pyAWS_PROVISIONER_FORWARDED_RUNTIME_ENV_KEYS(the sourceengine.ecsimports)restrict-provisioner-jobsNo Terraform change: the value is already rendered.
Verification
tests/platform/test_gcp_job_launcher_manifests.py,tests/shared/cloud/test_aws_runtime_role_parity.py,tests/engine/ecs/test_aws_provisioner_env.pypass.test_contract.py/test_runtime_inventory.pypass against the regenerated contract.