Repository navigation
feat(packer): optional AD content seed for the AWS pre-promoted DC bake - #2534
Merged
Merged
Conversation
The GCE dc-prebaked template stages a scenario's AD content seed for finalize.ps1; the AWS template ran a staged seed but had no way to stage one. dc_content_script now does so when set, and an empty value still bakes the base DC. As on GCE, finalize accepts Windows' 16001 status when the seed rotates the Administrator password before Packer queries the completed elevated task. The two pkrvars files are reformatted for the current packer fmt.
Resolve the modify/delete conflict on shifter/packer/proof.pkrvars.hcl by accepting dev's deletion: the proof tenant was decommissioned, so its packer var-file is gone. The dc-prebaked content-seed feature (dc-prebaked.pkr.hcl, variables.pkr.hcl, dev.pkrvars.hcl, test_packer.py) is unaffected.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The GCE
dc-prebakedtemplate stages a scenario's AD content seed forfinalize.ps1. The AWS template'sfinalize.ps1already runs a staged seed, but the template had no way to stage one, so a scenario could not bake its own directory on AWS without carrying scenario content in Shifter.dc_content_script(default empty) stages the given seed atC:\shifter-build\content-seed.ps1. Both staging provisioners are skipped when it is empty, so the baseinternal.shifterDC bakes as before.dev.pkrvars.hclandproof.pkrvars.hclare reformatted for the currentpacker fmt(whitespace only).No scenario content is added; a scenario keeps its seed and profile var-file in its own repository.
Verification
tests/test_packer.pypasses (112), andpacker validateis clean with and withoutdc_content_script.boreas.local, ran the seed throughfinalize.ps1(OUs, users, groups and shares verified in the transcript) and registered the AMI.