Skip to content

82/fix view btn width #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BeckettFrey merged 2 commits into from
Apr 14, 2026
Merged

82/fix view btn width #105

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
67303bb
Fix button width inconsistency
BeckettFrey Apr 14, 2026
b1ba441
Migrate to table style
BeckettFrey Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,14 @@ repos:
args: [--fix]
- id: ruff-format

- repo: https://github.com/pre-commit/mirrors-mypy
rev: v1.19.1
- repo: local
hooks:
- id: mypy
name: mypy
entry: uv run --only-group dev mypy .
language: system
types: [python]
pass_filenames: false

- repo: https://github.com/pre-commit/pre-commit-hooks
rev: v6.0.0
Expand Down
1 change: 0 additions & 1 deletion src/voxkit/gui/frameworks/categorical_table/categorical_table.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,6 @@ def update_display(self):
button_layout.setAlignment(Qt.AlignmentFlag.AlignCenter)

view_btn = QPushButton("View")
view_btn.setFixedSize(60, 24)
view_btn.setStyleSheet(Buttons.TABLE_VIEW)
view_btn.clicked.connect(lambda checked, idx=row_idx: self.view_item_details(idx))
button_layout.addWidget(view_btn)
Expand Down
13 changes: 4 additions & 9 deletions src/voxkit/gui/pages/datasets/datasets_page.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -539,18 +539,15 @@ def _create_alignment_action_buttons(self, alignment: alignments.AlignmentMetada
layout.setContentsMargins(5, 2, 5, 2)
layout.setSpacing(5)

button_style = Buttons.SUCCESS_SMALL

# Delete button
delete_btn = QPushButton("Delete")
delete_btn.setMaximumWidth(60)
delete_btn.setStyleSheet(Buttons.DELETE_SMALL)
delete_btn.clicked.connect(lambda: self._delete_alignment(alignment))
layout.addWidget(delete_btn)

# View button
view_btn = QPushButton("View")
view_btn.setStyleSheet(button_style)
view_btn.setStyleSheet(Buttons.TABLE_VIEW)
view_btn.clicked.connect(lambda: self._view_alignment(alignment))
layout.addWidget(view_btn)

Expand Down Expand Up @@ -810,15 +807,13 @@ def _create_dataset_action_buttons(self, dataset_meta: DatasetMetadata):
"""
widget = QWidget()
layout = QHBoxLayout(widget)
layout.setContentsMargins(0, 0, 0, 0)
layout.setContentsMargins(5, 2, 5, 2)
layout.setSpacing(5)
layout.setAlignment(Qt.AlignmentFlag.AlignCenter)

button_style = Buttons.TABLE_VIEW

# Details button
details_btn = QPushButton("Details")
details_btn.setFixedSize(80, 24)
details_btn.setStyleSheet(button_style)
details_btn.setStyleSheet(Buttons.TABLE_VIEW)
details_btn.clicked.connect(lambda: self._view_dataset_details(dataset_meta))
layout.addWidget(details_btn)

Expand Down
2 changes: 2 additions & 0 deletions src/voxkit/gui/styles/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,6 +257,8 @@ class Buttons:
font-size: 12px;
font-weight: bold;
color: {Colors.TEXT_SECONDARY};
min-width: 60px;
min-height: 24px;
}}
QPushButton:hover {{
background-color: {Colors.LIGHT_GRAY};
Expand Down
Loading