Fix alignment button rendering, metadata updates, and dataset state#84
Merged
Conversation
* Initial plan * fix: add layout.addWidget(view_btn) in _create_alignment_action_buttons Agent-Logs-Url: https://github.com/BrainBehaviorAnalyticsLab/voxkit-desktop/sessions/fd065a62-0e2c-4934-aae9-9420824c8957 Co-authored-by: BeckettFrey <83560790+BeckettFrey@users.noreply.github.com> * fix: correct alignment dict key references in _view_alignment --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: BeckettFrey <83560790+BeckettFrey@users.noreply.github.com>
…Error (#76) * Initial plan * fix: update_dataset_metadata handles partial update dicts without KeyError Agent-Logs-Url: https://github.com/BrainBehaviorAnalyticsLab/voxkit-desktop/sessions/26ca3ecd-bd76-4725-a6cc-05070880986d Co-authored-by: BeckettFrey <83560790+BeckettFrey@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: BeckettFrey <83560790+BeckettFrey@users.noreply.github.com>
* Initial plan * Fix empty-state bug in refresh_datasets: check metadata_list not the datasets module Agent-Logs-Url: https://github.com/BrainBehaviorAnalyticsLab/voxkit-desktop/sessions/9a9edc69-7179-41de-9459-9a6f265a0cf3 Co-authored-by: BeckettFrey <83560790+BeckettFrey@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: BeckettFrey <83560790+BeckettFrey@users.noreply.github.com>
…INE (#75) * Initial plan * fix: reload_models iterates all engines instead of hardcoding W2TGENGINE Agent-Logs-Url: https://github.com/BrainBehaviorAnalyticsLab/voxkit-desktop/sessions/003f14fe-b32d-4938-9a69-f6efc8a5087d Co-authored-by: BeckettFrey <83560790+BeckettFrey@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: BeckettFrey <83560790+BeckettFrey@users.noreply.github.com>
* lint: auto fixes applied * format: auto fixes applied * ci: all passing * typecheck: passing and issues resolved (no checking untyped defs for now)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a range of improvements across type annotations, runtime safety, and UI robustness in the codebase. The changes focus on enhancing type safety (with more explicit typing and runtime assertions), improving error handling, and making the GUI components more robust against potential
Nonevalues. There are also some minor code cleanups and dependency updates.Type Safety and Runtime Assertions:
hooks/hook-nltk.pyandsrc/voxkit/engines/base.pyto clarify expected data types. [1] [2]Nonebefore use indefault_analyzer.py.GUI Robustness and Cleanups:
Nonebefore accessing or modifying headers, views, or parent widgets, preventing potential runtime errors. [1] [2] [3] [4] [5] [6] [7]parentto_parent_widgetin dialogs) and fixed minor typos in comments. [1] [2]Dependency and Configuration Updates:
pyproject.toml(addedtypes-PyYAML) and enhanced mypy configuration for stricter type checking and better diagnostics. [1] [2]Minor Code Cleanups and Imports:
Other Fixes:
# type: ignorefor a type assignment in a typeguard patch and made minor stylistic changes for code clarity. [1] [2] [3] [4]These changes collectively improve the maintainability, reliability, and clarity of the codebase.