Skip to content

Fix alignment button rendering, metadata updates, and dataset state#84

Merged
BeckettFrey merged 8 commits into
mainfrom
release
Apr 9, 2026
Merged

Fix alignment button rendering, metadata updates, and dataset state#84
BeckettFrey merged 8 commits into
mainfrom
release

Conversation

@BeckettFrey

Copy link
Copy Markdown
Member

This pull request introduces a range of improvements across type annotations, runtime safety, and UI robustness in the codebase. The changes focus on enhancing type safety (with more explicit typing and runtime assertions), improving error handling, and making the GUI components more robust against potential None values. There are also some minor code cleanups and dependency updates.

Type Safety and Runtime Assertions:

  • Added explicit type annotations in files like hooks/hook-nltk.py and src/voxkit/engines/base.py to clarify expected data types. [1] [2]
  • Introduced runtime assertions to ensure variables are not of unexpected types (e.g., checking that metadata and messages are not strings before accessing as dicts) in engine and startup routines. [1] [2] [3] [4] [5] [6]
  • Added an assertion to ensure color values are not None before use in default_analyzer.py.

GUI Robustness and Cleanups:

  • Improved PyQt6 GUI components to check for None before accessing or modifying headers, views, or parent widgets, preventing potential runtime errors. [1] [2] [3] [4] [5] [6] [7]
  • Refactored variable names for clarity (e.g., parent to _parent_widget in dialogs) and fixed minor typos in comments. [1] [2]

Dependency and Configuration Updates:

  • Updated development dependencies in pyproject.toml (added types-PyYAML) and enhanced mypy configuration for stricter type checking and better diagnostics. [1] [2]

Minor Code Cleanups and Imports:

  • Cleaned up and reordered imports for consistency and removed unused imports in several files. [1] [2] [3] [4]
  • Standardized string formatting and download calls for NLTK resources. [1] [2]

Other Fixes:

  • Added # type: ignore for a type assignment in a typeguard patch and made minor stylistic changes for code clarity. [1] [2] [3] [4]

These changes collectively improve the maintainability, reliability, and clarity of the codebase.

Copilot AI and others added 8 commits April 8, 2026 16:38
* Initial plan

* fix: add layout.addWidget(view_btn) in _create_alignment_action_buttons

Agent-Logs-Url: https://github.com/BrainBehaviorAnalyticsLab/voxkit-desktop/sessions/fd065a62-0e2c-4934-aae9-9420824c8957

Co-authored-by: BeckettFrey <83560790+BeckettFrey@users.noreply.github.com>

* fix: correct alignment dict key references in _view_alignment

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: BeckettFrey <83560790+BeckettFrey@users.noreply.github.com>
…Error (#76)

* Initial plan

* fix: update_dataset_metadata handles partial update dicts without KeyError

Agent-Logs-Url: https://github.com/BrainBehaviorAnalyticsLab/voxkit-desktop/sessions/26ca3ecd-bd76-4725-a6cc-05070880986d

Co-authored-by: BeckettFrey <83560790+BeckettFrey@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: BeckettFrey <83560790+BeckettFrey@users.noreply.github.com>
* Initial plan

* Fix empty-state bug in refresh_datasets: check metadata_list not the datasets module

Agent-Logs-Url: https://github.com/BrainBehaviorAnalyticsLab/voxkit-desktop/sessions/9a9edc69-7179-41de-9459-9a6f265a0cf3

Co-authored-by: BeckettFrey <83560790+BeckettFrey@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: BeckettFrey <83560790+BeckettFrey@users.noreply.github.com>
…INE (#75)

* Initial plan

* fix: reload_models iterates all engines instead of hardcoding W2TGENGINE

Agent-Logs-Url: https://github.com/BrainBehaviorAnalyticsLab/voxkit-desktop/sessions/003f14fe-b32d-4938-9a69-f6efc8a5087d

Co-authored-by: BeckettFrey <83560790+BeckettFrey@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: BeckettFrey <83560790+BeckettFrey@users.noreply.github.com>
* lint: auto fixes applied

* format: auto fixes applied

* ci: all passing

* typecheck: passing and issues resolved (no checking untyped defs for now)
@BeckettFrey BeckettFrey merged commit cb5859d into main Apr 9, 2026
4 of 6 checks passed
@BeckettFrey BeckettFrey deleted the release branch April 9, 2026 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants