Fix code quality: resolve all ruff and mypy errors#9
Merged
Conversation
Co-authored-by: BeckettFrey <83560790+BeckettFrey@users.noreply.github.com>
Co-authored-by: BeckettFrey <83560790+BeckettFrey@users.noreply.github.com>
Co-authored-by: BeckettFrey <83560790+BeckettFrey@users.noreply.github.com>
Co-authored-by: BeckettFrey <83560790+BeckettFrey@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Implement minimal invasive changes
Fix code quality: resolve all ruff and mypy errors
Dec 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressed all code quality issues across the codebase by fixing linting errors and type checking violations.
Changes
Formatting and Linting
subprocess.run()withshell=Trueto use list argumentsType Checking
TypedDict syntax errors: Fixed invalid subscript syntax used for type hints
Literal types for discriminated unions:
Path vs str mismatches: Changed TypedDict fields expecting
Pathobjects to receivePathinstead ofstr(path)Missing type annotations: Added explicit type hints for class attributes and variables where mypy couldn't infer them
Function signature mismatches: Aligned overridden method signatures with base class definitions
Verification
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
https://api.github.com/repos/BrainBehaviorAnalyticsLab/PyPLLRComputer/commits/HEAD/home/REDACTED/.local/bin/uv uv sync(http block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.