Skip to content

fix: don't mark first launch complete on startup script error #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BeckettFrey merged 2 commits into from
Apr 14, 2026
Merged

fix: don't mark first launch complete on startup script error #99

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e3b9f75
Initial plan
Copilot Apr 14, 2026
61d9573
fix: don't mark first launch complete on startup script error
Copilot Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions src/voxkit/gui/workers/startup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,11 +98,7 @@ def on_error(error_msg: str):
logger.error("Startup script failed: %s", error_msg)
loading_dialog.update_message(f"Error: {error_msg}")
app.processEvents()
# Still mark as complete to avoid running again
mark_first_launch_complete()
# Wait a bit to show error before closing
from PyQt6.QtCore import QTimer

# Do NOT mark first launch complete on error — allow retry on next launch
QTimer.singleShot(2000, loading_dialog.close_gracefully)

worker.finished.connect(on_finished)
Expand Down
Loading