Fix CI silent failure#26
Merged
Merged
Conversation
ktsiknos-brainchip
force-pushed
the
fix_ci_silent_failure
branch
from
e38efd1 to
0db6c8a
Compare
ktsiknos-brainchip
requested review from
Dominique468,
abih-brainchip,
dmclellandbc,
fernez-brainchip,
kmanninen,
nguilbaud-brainchip and
nikunj95
Dominique468
approved these changes
Apr 21, 2026
abih-brainchip
approved these changes
Apr 21, 2026
dmclellandbc
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed silent CI failure by propagating the subprocess exit code in
post_filter.pyand addingset -eto the workflow loop.Relates to #25 silent failure.
Tested on top of #25 commit in https://github.com/Brainchip-Inc/models/actions/runs/24716797172/job/72295209946?pr=26.