new flag: allow other#10
Conversation
when allow other is set, we ensure that the option "user_allow_other" option is correctly set in `/etc/fuse.conf`
with a default breaking change, allow_other is now false we add the parameter to the type and provider an open question is still whether allow_other can be extracted from the mount options, in which case it would need to become a property ;)
| owner ||= 0 | ||
| group = options.sub(%r{.*group(_id)?=([^,)]).*}, '\2') if options =~ %r{group(_id)?} | ||
| group ||= 0 | ||
| # XXX: is allow_others in options? |
There was a problem hiding this comment.
@Salokyn: can you please verify on your systems if allow_other somehow shows up in mount options?
There was a problem hiding this comment.
Yes
$mount
swiftks://auth.cloud.ovh.net/GRA1:nextcloud/ on /mnt/s3ql/www/nextcloud type fuse.s3ql (rw,nosuid,nodev,relatime,user_id=33,g
roup_id=33,default_permissions,allow_other)
igalic
left a comment
igalic
left a comment
There was a problem hiding this comment.
i… i just don't know what this was supposed to be about…
| end | ||
|
|
||
| # TODO: This *arguments paramether is kinda pointless | ||
| def mount_s3ql(*arguments) |
There was a problem hiding this comment.
i don't know what i thought here, this code is… weird.
this now allows us easily extract and add them as needed.
add it to the list of properties in our tests, too
|
@Salokyn do you think you can give this code a test-drive and lemme know how it's working for you? if it's all good, i'll merge and release |
|
aaaaand we have travis running checks again! |
|
How can I test it properly ? |
2 participants
This pr adds a flag
allow_otheras per #8We add it to both, the
s3qlinit class, and tos3ql_mount.