Skip to content

Get period #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ghislainfourny merged 2 commits into from
Mar 24, 2026
Merged

Get period #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c28621f
Fix period duration string.
Mar 24, 2026
ec1814a
Merge branch 'main' of github.com:BrelLibrary/brel into GetPeriod
Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion brel/characteristics/period_characteristic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ def __str__(self) -> str:
if self.__is_instant:
return f"{self.__instant_date}"
else:
return f"{self.__start_date} - {self.__end_date}"
return f"{self.__start_date}/{self.__end_date}"

def __eq__(self, __value: object) -> bool:
if not isinstance(__value, PeriodCharacteristic):
Expand Down
4 changes: 2 additions & 2 deletions tests/core_tests/test_fact.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,8 @@ def test_qname_getters():

assert fact.get_unit() == None, "Expected None as fact unit is not defined"
assert (
str(fact.get_period()) == "2022-09-25 - 2023-07-01"
), "Expected '2022-09-25 - 2023-07-01' as fact unit is 'from 2022-09-25 to 2023-07-01'"
str(fact.get_period()) == "2022-09-25/2023-07-01"
), "Expected '2022-09-25/2023-07-01' as fact unit is 'from 2022-09-25 to 2023-07-01'"
assert (
str(fact.get_concept()) == "dei:DocumentQuarterlyReport"
), "Expected 'dei:DocumentQuarterlyReport' as fact concept is 'dei:DocumentQuarterlyReport'"
Expand Down
Loading