2.4.0: Google Reader, keyboard navigation, and three Miniflux fixes

[BrendonJL]

Releases 2.4.0: Google Reader API support, keyboard navigation, and six user-visible fixes — three of which shipped broken in 2.3.3.

41 commits, 49 files, ~8.4k insertions. Large, but it splits cleanly into a refactor, two features, and the fixes that refactor made findable.

User-visible

Google Reader API support — adds FreshRSS, Tiny Tiny RSS (via its plugin), Inoreader, TheOldReader and BazQux as sources. One protocol rather than one integration each. Verified end to end against both Miniflux and FreshRSS.

Keyboard navigation — j/k move, o/Enter open, m toggles read, s saves, Space selects, g g/G jump, / searches, r refreshes, A marks all read, ? lists the bindings. m and s act on the whole selection when one exists. Esc unwinds one layer per press: help, then search, then selection, then cursor.

Fixed — mark-as-read never reached Miniflux. Every read made in Miniflux mode stayed local. The API types entry_ids as int64; the widget sent strings, so the server rejected the request with HTTP 400. Starring was unaffected because it puts the id in the URL path, where the type is never checked — which is why it survived: half the feature worked.

Fixed — Miniflux API errors were silently discarded. curl exits 0 on an HTTP 400 and the widget only reacted to a non-zero exit, so failures vanished without a toast or log line. This is what hid the bug above. Now uses --fail-with-body.

Fixed — stale feed status in settings; search needing two clicks before it accepted typing; the search button disappearing during selection; selection being silently dropped by a search; two feeds sharing a URL rendering each other's names; curl exit 6 instead of "Could not resolve host".

Internal

The widget no longer branches on the source mode anywhere — 17 sourceMode === checks became one dispatch point. Backends are plain objects exposing capabilities and returning request descriptors ({ argv, parse, timeoutMs, meta }) that perform no I/O; QML runs the process and owns nothing else. Adding Google Reader was a new file rather than a new branch in twenty places.

Two constraints worth knowing before editing any module (both in README → Architecture):

• No .pragma library. It is not valid JavaScript and breaks require() in the tests. CI greps for it.
• Modules never require() each other. Neither require nor .import works in both QML and Node, so siblings are passed in: createBackends({ FeedParser, ReaderState, GoogleReader }).

Testing

240 → 624 tests, plus a QML smoke harness and two live suites.

The interesting tier is tests/live-*.js, which run the modules' own generated argv against real Miniflux and FreshRSS servers. They are deliberately not *.test.js, so CI never runs them. Both Miniflux bugs above were invisible to the unit tests — the requests were well-formed and the server rejected them. That is the gap this tier exists to close.

tests/qml/run.sh runs QML headless. This repo previously assumed that was impossible; it needs QT_QPA_PLATFORM=offscreen and QML2_IMPORT_PATH, and without the second it fails silently with "Did not load any objects".

CI gained a QML syntax check via qmlformat. Not qmllint — it is a type checker and the DMS shell it would need cannot be installed on a runner (docs/ci/README.md records both failed attempts).

Reviewing this

It is large, so in rough order of value:

1. Backends.js + GoogleReader.js — the interface and its hardest implementation.
2. ChainRunner.js — small, and the one place a mistake finalises a fetch on partial results.
3. DankRssWidget.qml's fetchAllFeeds / runChainLink — the only untested code that matters; it has no automated coverage at all.
4. Everything else is tests and docs.

Design docs are in docs/plans/, indexed in docs/plans/README.md with a status line saying which still describe reality.

Known limitation: Google Reader has only been tested against Miniflux and FreshRSS. Those two already disagree — Miniflux returns a bare [] with HTTP 200 for stream/contents while FreshRSS implements it, and the T= post token is required by Miniflux but optional on FreshRSS. Other servers may deviate again.