Fix search focus and selection - #9
Merged
Merged
Conversation
…lters Three fixes from the search-fixes design doc: - The search field ignored typing until a second click. DMS maps acceptsKeyboardFocus onto layer-shell WlrKeyboardFocus.OnDemand, which grants focus only on a click landing while the surface is already eligible -- and it was not, since the flag was bound to searchActive and so flipped true only after the click that opened search. Widened to include pointer hover via a HoverHandler, plus a deferred forceActiveFocus retry. - The search toggle vanished while items were checked, because the selection bar replaces the whole header row. Factored the toggle into a shared Component and gave the selection bar its own instance. - Selection was pruned against the visible set, so searching silently dropped it. Prunes against allItems now; the count label reports the hidden portion, derived from a cached visibleItems so it changes on the same debounced beat as the list. Tests: 271 -> 277 passing. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MRyF2uQvkQkcjbGHBsa7nS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three fixes from the search-fixes design doc:
acceptsKeyboardFocus onto layer-shell WlrKeyboardFocus.OnDemand, which
grants focus only on a click landing while the surface is already
eligible -- and it was not, since the flag was bound to searchActive
and so flipped true only after the click that opened search. Widened
to include pointer hover via a HoverHandler, plus a deferred
forceActiveFocus retry.
selection bar replaces the whole header row. Factored the toggle into
a shared Component and gave the selection bar its own instance.
dropped it. Prunes against allItems now; the count label reports the
hidden portion, derived from a cached visibleItems so it changes on
the same debounced beat as the list.
Tests: 271 -> 277 passing.
Co-Authored-By: Claude Opus 5 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_01MRyF2uQvkQkcjbGHBsa7nS