infra: drop redis container — RedisService was unused (HOL-22) - #101
Merged
Conversation
4 tasks
RedisService was registered in DI as a singleton but no code path
actually injected it. Pure dead infrastructure carrying its own
container, network port, persistent volume, and StackExchange.Redis
package dependency.
Removed:
- src/dotnet/src/HoldFast.Shared/Redis/{RedisService, RedisOptions}
- src/dotnet/tests/HoldFast.Shared.Tests/Redis/
- HoldFast.Shared.csproj: StackExchange.Redis package reference
- Program.cs: Redis DI registration + using
- compose.yml: redis service + redis-data volume
- compose.hobby-dotnet.yml: Redis__Configuration env mapping
- .env.example: REDIS_IMAGE_NAME, REDIS_PASSWORD
- env.sh: REDIS_EVENTS_STAGING_ENDPOINT exports
If a future code path actually needs caching, IMemoryCache (in-process)
covers self-hosted scale; users at multi-node scale can re-add Redis
explicitly.
Verified: docker compose ps now shows 6 HoldFast containers (was 7
after HOL-21). Smoke test passes end-to-end.
Stacks on HOL-21. Subtask of HOL-17. Closes HOL-22.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
BrewingCoder
force-pushed
the
issue-22-drop-redis
branch
from
May 9, 2026 14:42
c674278 to
d5e907d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RedisServicewas registered in DI as a singleton but no code path actually injected it. Pure dead infrastructure: a container, a port, a persistent volume, and aStackExchange.Redispackage dependency carrying their own footprint with zero callers.Removed
src/dotnet/src/HoldFast.Shared/Redis/{RedisService, RedisOptions}src/dotnet/tests/HoldFast.Shared.Tests/Redis/HoldFast.Shared.csproj:StackExchange.Redispackage referenceProgram.cs: Redis DI registration + usingcompose.yml:redisservice +redis-datavolumecompose.hobby-dotnet.yml:Redis__Configurationenv mapping.env.example:REDIS_IMAGE_NAME,REDIS_PASSWORDenv.sh:REDIS_EVENTS_STAGING_ENDPOINTexportsNet
8 files changed, +4 / -163 lines (basically just config-comment additions vs full Redis cleanup).
Forward-compat
If a future code path actually needs caching:
IMemoryCache(in-process)Verified
docker compose psnow shows 6 HoldFast containers (was 7 after HOL-21)../infra/docker/smoke-test-ingest.sh) passes end-to-end.Stacks on #100. Subtask of HOL-17. Closes HOL-22.
🤖 Generated with Claude Code