Report probe-found-but-target-unreachable for STLink#391
Merged
Conversation
The probe-detection heuristic in _launch_openocd only recognized the "Interface ready" marker, emitted by the DAP (SWD/JTAG) transports. STLink uses the hla transport, which never prints it — so a successfully-detected STLink that failed at the target-connection step (e.g. "init mode failed (unable to connect to the target)") fell through to the misleading "Unable to autodetect & connect to debugging probe" message. Treat "Target voltage", "init mode failed", and "unable to connect to the target" as additional probe-found markers so these cases report accurately, and correct the power-button hint to release (not hold) the button while connecting. Fixes #390. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The probe-detection heuristic in _launch_openocd only recognized the "Interface ready" marker, emitted by the DAP (SWD/JTAG) transports. STLink uses the hla transport, which never prints it — so a successfully-detected STLink that failed at the target-connection step (e.g. "init mode failed (unable to connect to the target)") fell through to the misleading "Unable to autodetect & connect to debugging probe" message.
Treat "Target voltage", "init mode failed", and "unable to connect to the target" as additional probe-found markers so these cases report accurately, and correct the power-button hint to release (not hold) the button while connecting. Fixes #390.