Skip to content

fix: avoid int pop payload in news filter bottom sheet - #218

Open
Pankajbarad18 wants to merge 1 commit into
BrightDV:mainfrom
Pankajbarad18:fix/news-filter-bottom-sheet-type-error
Open

fix: avoid int pop payload in news filter bottom sheet#218
Pankajbarad18 wants to merge 1 commit into
BrightDV:mainfrom
Pankajbarad18:fix/news-filter-bottom-sheet-type-error

Conversation

@Pankajbarad18

Copy link
Copy Markdown

Small fix: use Navigator.of(context).pop() instead of pop(0) to avoid returning an int when showCustomBottomSheet returns Future<String?>.

Fixes
Fixes #217

How to reproduce

    1. Launch app.
    2. Tap the news filter icon.
    3. Select a topic and tap Apply.
    4. Previously the app threw: TypeError: 0: type 'int' is not a subtype of type 'String?'.

What I changed

    - [ui.dart]: changed Navigator.of(context).pop(0) → Navigator.of(context).pop().

Testing

    - Manual: followed reproduction steps and verified no TypeError and navigation to the filtered NewsFeed works.

Notes for maintainers

    - Small, isolated change; no breaking behavior; ready to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix type mismatch when applying news filter bottom sheet

1 participant