Conversation
Collaborator
Author
|
Approved for merge by Ryan (@foundev). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the regression coverage issue #47 asks for on top of the either-platform validator from #48.
Every agent-side entry point now has a test that only passes if it keeps delegating to
acpvalidate.AbsolutePath:LoadSession,ResumeSession,ListSessionsaccept/(fails on Windows CI under a host-relative check), andNewSessionWithOptionsaccepts drive-absolute and UNC paths from a POSIX host.mcp:NewSession,ResumeSession,ForkSessionaccept/.unstable.ForkSessionaccepts/.ResumeSession,ListSessionsaccept/.v2/mcp: stdio command paths accept both a POSIX and a Windows absolute form.The host-local checks in
clienthostand the v2 runner are unchanged and intentionally stay host-native.Verification:
go test -race ./...,go vet ./..., andGOOS=windows go vet ./...all pass locally.Fixes #47