Bind supplemental probes to an explicit ready contract - #276
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release preparer and launchers accept an explicit versioned contract, but the Python supplemental probe expects its script to be the last command argument and the OpenTaint probe requires a fixed two-argument command and canonical inventory path. Those checks prevent a reviewed ready contract from being used without changing the disabled preparation contract.
Accept an explicit
--contractonly when it names the exact consumed contract inside the versioned execution-plan directory. OpenTaint follows the hash-bound inventory reference there. Preserve the default canonical invocation for the preparation workflow. No arbitrary file overlay or external preparation driver is introduced.Validation: 17 focused probe tests and 11 planning-contract tests pass. New tests execute mocked controls from a
final-01contract/inventory, prove disabled canonical bytes remain unchanged, and reject a mismatched contract argument before output creation. Execution remains disabled; no native analyzer was run.