Make tool details readable and color transcript output - #12
Merged
Merged
Conversation
foundev
commented
Sep 26, 2026
foundev
left a comment
Contributor
Author
There was a problem hiding this comment.
Self-review completed. Two issues found in the original PR revision are now fixed:
- Text containing shell globs or exponent operators could be interpreted as Markdown. Tool output now preserves these literals; assistant Markdown rendering is unchanged.
- The cancellation notice could exceed a narrow details viewport. It now wraps within the available width.
Regression coverage includes both cases, false status-color matches, and success/warning/error colors. I also checked structured payload retention, exact numeric values, non-text markers, unified diff context, control-sequence sanitization, light/dark title colors, and the ACP/keyboard flow for Ctrl+O and draft restoration.
make check, the production build, and formatting checks pass locally. No remaining findings in this review; merge is pending CI on the final revision.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ctrl+O previously displayed serialized tool payloads, leaving commands and multiline output buried in JSON. It now renders labeled inputs, results, file locations, and unified diffs, with decoded multiline values and colors for additions, removals, and output status. Unknown structured fields remain readable, and session files retain the original payloads.
Compact transcript rows now color tool titles by kind, distinguish failures and cancellation, and style file paths and change labels separately. Terminal commands and success/warning/error lines also receive color. This PR includes the previously committed build-version label in the prompt border.
Validation:
make check(race tests and vet), a production build, and formatting checks. Added coverage for structured and non-text content, exact numbers and empty values, light/dark themes, narrow Unicode layouts, control-sequence sanitization, and a live ACP flow exercising Ctrl+O, scrolling, updates, and draft restoration.