Skip to content

Make tool details readable and color transcript output - #12

Merged
foundev merged 3 commits into
mainfrom
fix/readable-tool-output
Sep 26, 2026
Merged

foundev merged 3 commits into
mainfrom
fix/readable-tool-output

Conversation

@foundev

@foundev foundev commented Sep 26, 2026

Copy link
Copy Markdown
Contributor

Ctrl+O previously displayed serialized tool payloads, leaving commands and multiline output buried in JSON. It now renders labeled inputs, results, file locations, and unified diffs, with decoded multiline values and colors for additions, removals, and output status. Unknown structured fields remain readable, and session files retain the original payloads.

Compact transcript rows now color tool titles by kind, distinguish failures and cancellation, and style file paths and change labels separately. Terminal commands and success/warning/error lines also receive color. This PR includes the previously committed build-version label in the prompt border.

Validation: make check (race tests and vet), a production build, and formatting checks. Added coverage for structured and non-text content, exact numbers and empty values, light/dark themes, narrow Unicode layouts, control-sequence sanitization, and a live ACP flow exercising Ctrl+O, scrolling, updates, and draft restoration.

@foundev foundev left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self-review completed. Two issues found in the original PR revision are now fixed:

  • Text containing shell globs or exponent operators could be interpreted as Markdown. Tool output now preserves these literals; assistant Markdown rendering is unchanged.
  • The cancellation notice could exceed a narrow details viewport. It now wraps within the available width.

Regression coverage includes both cases, false status-color matches, and success/warning/error colors. I also checked structured payload retention, exact numeric values, non-text markers, unified diff context, control-sequence sanitization, light/dark title colors, and the ACP/keyboard flow for Ctrl+O and draft restoration.

make check, the production build, and formatting checks pass locally. No remaining findings in this review; merge is pending CI on the final revision.

@foundev
foundev merged commit 95a4d36 into main Sep 26, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant