Repository navigation
Support Windows builds, tests, and releases - #14
Merged
Merged
Conversation
Bump acp-go to the commit that makes internal/osrun build on Windows, which is what broke `go install` there. localPath converted "/" to "\" before rejecting paths containing "\", so on Windows every registry binary command (even "./agent.exe") was refused as unsafe. Backslashes are now checked on the archive name as published, before the conversion. Tests fake npx with a .cmd on Windows and skip Unix permission-bit checks there. CI gains windows-latest (gofmt stays on Unix, since CRLF checkouts look unformatted), and GoReleaser publishes Windows zips. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vfh8rxnMX9hmJX8fKPFPMK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
go install github.com/BrokkAi/micro-acp@latestfails on Windows because acp-go'sinternal/osrunused Unix-only syscalls. While testing on Windows, a real micro-acp bug also turned up: every registry binary agent was rejected as an unsafe path.Changes
a5c9a46(merged Build and test on Windows acp-go#43), which makesinternal/osrunbuild on Windows.registry.localPathbug (regression test added): it ranfilepath.FromSlashand then rejected any name containing\, so on Windows./agent.exeor./nested/agentbecame.\agent.exeand was refused. Backslashes are now checked on the name as published;IsLocalstill guards traversal.npxis written asnpx.cmdon Windows (PATHEXT lookup); 0600 permission-bit assertions are skipped on Windows, where Go reports 0666.windows-latestadded to the matrix.gofmt -lstays on Linux/macOS (CRLF checkouts report every file); dependency verification runs under bash..zip.Verification
go build,go vet,go test -count=1 ./...all pass (race not run locally: no cgo).GOOS=linux/GOOS=darwin go vet ./...clean.🤖 Generated with Claude Code