Repository navigation
Fix Bifrost diagnostics and reference report reproduction - #202
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bifrost structured scan failures lost their reason and source context in UsageBench reports. Preserve those details without changing failure scoring. Reference-image publication also failed reproduction when the same verified image appeared under an immutable registry reference and a local tag; compare those forms using their equal validated image digests.
Key Changes:
Touch Points:
src/runners/bifrost.rssrc/runners/report_compare.rsValidation: 278 Rust tests and all 59 corpus documents passed before the comparator patch; 12 focused comparator tests and 2 reference-image tests passed after it. Affected-file formatting and diff checks passed. Repository-wide formatting reports pre-existing drift in
src/promotion.rs, reproduced on the base.The reference comparison failure was verified on exact base
3cd9907a4fd6e0c44d1ff6172e13647674e7cf74, main run 37283922007, for both gopls and Bifrost after passing smoke tests.