Skip to content

Fix Bifrost diagnostics and reference report reproduction - #202

Merged
DavidBakerEffendi merged 2 commits into
mainfrom
dave/repair-bifrost-schema
Oct 5, 2026
Merged

DavidBakerEffendi merged 2 commits into
mainfrom
dave/repair-bifrost-schema

Conversation

@DavidBakerEffendi

@DavidBakerEffendi DavidBakerEffendi commented Oct 5, 2026 •

Copy link
Copy Markdown
Collaborator

Bifrost structured scan failures lost their reason and source context in UsageBench reports. Preserve those details without changing failure scoring. Reference-image publication also failed reproduction when the same verified image appeared under an immutable registry reference and a local tag; compare those forms using their equal validated image digests.

Key Changes:

  • Retain current and legacy Bifrost scan failure diagnostics.
  • Accept differing display references only with equal valid SHA-256 image digests; preserve differing immutable references and digest failures. Add positive and near-miss regressions.

Touch Points:

  • src/runners/bifrost.rs
  • src/runners/report_compare.rs

Validation: 278 Rust tests and all 59 corpus documents passed before the comparator patch; 12 focused comparator tests and 2 reference-image tests passed after it. Affected-file formatting and diff checks passed. Repository-wide formatting reports pre-existing drift in src/promotion.rs, reproduced on the base.

The reference comparison failure was verified on exact base 3cd9907a4fd6e0c44d1ff6172e13647674e7cf74, main run 37283922007, for both gopls and Bifrost after passing smoke tests.

@DavidBakerEffendi DavidBakerEffendi changed the title Fix missing Bifrost scan failure diagnostics Fix Bifrost diagnostics and reference report reproduction Oct 5, 2026
@DavidBakerEffendi
DavidBakerEffendi merged commit 4b47742 into main Oct 5, 2026
5 checks passed
@DavidBakerEffendi
DavidBakerEffendi deleted the dave/repair-bifrost-schema branch October 5, 2026 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant