sec(auth): comparação constant-time do BEARER_TOKEN#148
Merged
Conversation
Bloco D do plano pós-diagnóstico (segurança). O token mestre era comparado com === (não constant-time): vazava timing que poderia ajudar a recuperar o token. Troca pelas duas comparações por safeEqual (timingSafeEqual + length-guard), o mesmo helper já usado em oauth.ts. Comportamento idêntico (verdadeiro sse igual). build+test verdes (1265/1265). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bloco D do plano pós-diagnóstico (segurança)
O
BEARER_TOKENmestre era comparado com===(não constant-time) em/mcpe/status, vazando timing que poderia ajudar a recuperar o token byte a byte.safeEqual(timingSafeEqual+ length-guard) — o helper já usado emoauth.ts. Comportamento idêntico (verdadeiro sse igual), agora sem o canal de timing.npm run build+npm testverdes (1265/1265).Itens do Bloco D que ficam para seu OK explícito (risco/escopo)
oauth.ts): muda persistência de credencial e depende deSECRETS_KEYna VPS — faço backward-compatible, mas merece confirmação.as unknown asno gate de auth (index.ts): exige redefinirTokenScopes(Workspace[]vs strings de friend) num caminho de segurança — decisão de modelagem deliberada.🤖 Generated with Claude Code