Repository navigation
Enforce exact firmware payload matching - #383
Closed
ZeldaMaster501 wants to merge 3 commits into
Closed
ZeldaMaster501 wants to merge 3 commits into
ZeldaMaster501 wants to merge 3 commits into
Conversation
Author
|
No description provided. |
ZeldaMaster501
force-pushed
the
agent/s928u-dzg1-app
branch
from
August 11, 2026 04:11
cee0f5f to
25b76de
Compare
Author
|
Currently traveling and had Codex work on a POC for my device's firmware. Did not realize that it had decided to open a pull request on the main repository. I'll reopen this pull request and or create a new one if this actually works on my device. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make payload selection fail closed on exact firmware identity instead of matching only the device model.
model, exactkernelRelease, and exact AndroidbuildId.Why
On
SM-S928U / S928USQS6DZG1, the legacy model-only feed can select the older DZF2 payload. That mismatch has already caused device crashes. This change prevents the app from downloading or running a payload unless the full firmware identity matches.Dependency / deployment order
This PR depends on payload PR BuSung-dev/Root-My-Galaxy-Payloads#195 and must be merged only after that payload/feed PR is available on the payload repository's main branch.
The exact DZG1 profile remains hardware-unvalidated; the companion payload PR intentionally limits it to one attempt and a fresh P0 session.