Skip to content

refactor safe area to handle android edge2edge #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AlaaN-Smadi wants to merge 1 commit into
base: master
Choose a base branch
from
Open

refactor safe area to handle android edge2edge #280

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion widget/assets/css/media.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ html {
font-size: 16px !important;
}

.slide.safe-area {
.slide {
padding-top: var(--bf-safe-area-inset-top) !important;
}
.caption {
Expand Down
7 changes: 5 additions & 2 deletions widget/assets/css/widget.app.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1020,7 +1020,7 @@ img.done-icon {
}

.playlist-empty-container {
height: calc(100vh - 5rem);
height: calc(100vh - 65px - var(--bf-safe-area-inset-bottom));
display: flex;
flex-direction: column;
align-items: center;
Expand Down Expand Up @@ -1466,6 +1466,8 @@ input[type="checkbox"]:checked+.subcategory-label.minus::before {
left: 0;
right: 0;
padding: 15px;
padding-bottom: calc(16px + var(--bf-safe-area-inset-bottom));
background-color: var(--bf-theme-background);
justify-content: center;
}

Expand All @@ -1484,14 +1486,15 @@ input[type="checkbox"]:checked+.subcategory-label.minus::before {
font-size: .875rem !important;
padding: 0 16px 0 16px !important;
height: 36px;
width: calc(100% - 32px);
}

.filter-funnel {
font-size: 1.5em;
color: var(--bf-theme-primary);
}

.slide.safe-area.launcher-with-filter {
.slide {
padding-top: var(--bf-safe-area-inset-top) !important;
}

Expand Down
5 changes: 0 additions & 5 deletions widget/controllers/widget.home.controller.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,6 @@

const isLauncher = window.location.href.includes('launcherPlugin');
const slideElement = document.querySelector(".slide");
if (isLauncher) {
slideElement.classList.add("safe-area");
} else {
slideElement.classList.remove("safe-area");
}

buildfire.navigation.onAppLauncherActive(() => {
$rootScope.refreshItems();
Expand Down
2 changes: 1 addition & 1 deletion widget/templates/layouts/now-playing.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ <h4 class="margin-zero ellipsis whiteTheme">{{NowPlaying.currentTrack.title}}</h
<!-- Playlist Overlay -->
<div ng-if="showPlaylist" class="overlay backgroundColorTheme slide"
style="position:fixed; top:0; left:0; width:100%; height:100%;">
<div class="overlay-content" style="position:absolute; top:0; left:0; height:100%; width: 100%; overflow:auto;">
<div class="overlay-content" style="position:absolute; top:0; left:0; height:100%; width: 100%; overflow:auto; padding-bottom: calc(16px + var(--bf-safe-area-inset-bottom));">
<div class="media-player-list-layout third-layout">
<div class="list-layout has-btns">
<div class="list-item overflow-hidden"
Expand Down