Skip to content

handle plugin top safe area #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AlaaN-Smadi wants to merge 1 commit into
base: master
Choose a base branch
from
Open

handle plugin top safe area #169

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions widget/assets/css/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
.plugin-list-container {
padding-top: var(--bf-safe-area-inset-top) !important;
}
/* Plugin CSS */
.plugin-slide img, .plugin-slide {
max-height: none !important;
Expand Down Expand Up @@ -1705,10 +1708,6 @@ input.volume-button[type=range]:focus::-ms-fill-upper {
border-bottom: 1px solid rgba(0, 0, 0, 0.12);
}

.safe-area-fix {
padding-top: 25px;
}

.list-layout {
overflow: auto;
}
Expand Down
11 changes: 0 additions & 11 deletions widget/controllers/widget.home.controller.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,17 +320,6 @@
window.location.reload();
}
};
buildfire.appearance.titlebar.isVisible(null, (err, isVisible) => {
if (err) return console.error(err);
WidgetHome.isTittlebarVisible = isVisible;
});

WidgetHome.isSafeArea = () => {
if (!WidgetHome.isTittlebarVisible && WidgetHome.data.content && !(WidgetHome.data.content.description || WidgetHome.data.content.carouselImages.length)) {
return true;
}
else return false;
}

WidgetHome.fetchFeed = (feed) => {
buildfire.appearance.ready();
Expand Down
2 changes: 1 addition & 1 deletion widget/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@
</head>
<body class="body-scroll">
<div class="main_view">
<div ng-show="showFeedList" data-back-img="{{backgroundImage}}" class="slide content infinite-scroll-parent">
<div ng-show="showFeedList" data-back-img="{{backgroundImage}}" class="slide content infinite-scroll-parent plugin-list-container">
<div ng-controller="WidgetHomeCtrl as WidgetHome">
<div ng-if="WidgetHome.data.design.itemListLayout"
ng-include="'templates/' + WidgetHome.data.design.itemListLayout+ '.html'">
Expand Down
1 change: 0 additions & 1 deletion widget/templates/List_Layout_1.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
</div>
<!------------ TABS ----------->
<div class="mdc-tab-bar" role="tablist" ng-if="WidgetHome.data.content.feeds.length > 1"
ng-class="{'safe-area-fix': WidgetHome.isSafeArea()}"
ng-init="WidgetHome.initializeTabs()">
<div class="mdc-tab-scroller">
<div class="mdc-tab-scroller__scroll-area">
Expand Down
3 changes: 1 addition & 2 deletions widget/templates/List_Layout_2.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,7 @@
</div>
<div>
<!------------ TABS ----------->
<div class="mdc-tab-bar" role="tablist" ng-if="WidgetHome.data.content.feeds.length > 1"
ng-class="{'safe-area-fix': WidgetHome.isSafeArea()}" ng-init="WidgetHome.initializeTabs()">
<div class="mdc-tab-bar" role="tablist" ng-if="WidgetHome.data.content.feeds.length > 1" ng-init="WidgetHome.initializeTabs()">
<div class="mdc-tab-scroller">
<div class="mdc-tab-scroller__scroll-area">
<div class="mdc-tab-scroller__scroll-content">
Expand Down
2 changes: 1 addition & 1 deletion widget/templates/List_Layout_3.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
</div>
<!------------ TABS ----------->
<div class="mdc-tab-bar" role="tablist" ng-if="WidgetHome.data.content.feeds.length > 1"
ng-class="{'safe-area-fix': WidgetHome.isSafeArea()}" ng-init="WidgetHome.initializeTabs()">
ng-init="WidgetHome.initializeTabs()">
<div class="mdc-tab-scroller">
<div class="mdc-tab-scroller__scroll-area">
<div class="mdc-tab-scroller__scroll-content">
Expand Down
2 changes: 1 addition & 1 deletion widget/templates/List_Layout_4.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
</div>
<!------------ TABS ----------->
<div class="mdc-tab-bar" role="tablist" ng-if="WidgetHome.data.content.feeds.length > 1"
ng-class="{'safe-area-fix': WidgetHome.isSafeArea()}" ng-init="WidgetHome.initializeTabs()">
ng-init="WidgetHome.initializeTabs()">
<div class="mdc-tab-scroller">
<div class="mdc-tab-scroller__scroll-area">
<div class="mdc-tab-scroller__scroll-content">
Expand Down
2 changes: 1 addition & 1 deletion widget/templates/List_Layout_5.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
</div>
<!------------ TABS ----------->
<div class="mdc-tab-bar" role="tablist" ng-if="WidgetHome.data.content.feeds.length > 1"
ng-class="{'safe-area-fix': WidgetHome.isSafeArea()}" ng-init="WidgetHome.initializeTabs()">
ng-init="WidgetHome.initializeTabs()">
<div class="mdc-tab-scroller">
<div class="mdc-tab-scroller__scroll-area">
<div class="mdc-tab-scroller__scroll-content">
Expand Down
2 changes: 1 addition & 1 deletion widget/templates/List_Layout_6.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
</div>
<!------------ TABS ----------->
<div class="mdc-tab-bar" role="tablist" ng-if="WidgetHome.data.content.feeds.length > 1"
ng-class="{'safe-area-fix': WidgetHome.isSafeArea()}" ng-init="WidgetHome.initializeTabs()">
ng-init="WidgetHome.initializeTabs()">
<div class="mdc-tab-scroller">
<div class="mdc-tab-scroller__scroll-area">
<div class="mdc-tab-scroller__scroll-content">
Expand Down