-
Notifications
You must be signed in to change notification settings - Fork 261
Migrate Strategic Accounts dashboard to agent-native #1595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
1365636
b30fdb1
2af7898
158f780
5db9e5a
81d78fb
a4a9668
494cd5d
9296e7d
9285334
acdb738
620b067
278ca16
b3c1e00
9a6c342
da21711
3e9a76d
53ee5ef
f609525
200a5d5
f17b4fa
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -114,6 +114,13 @@ export interface SqlPanel { | |
| export interface SqlDashboardConfig { | ||
| name: string; | ||
| description?: string; | ||
| /** | ||
| * Optional id of another dashboard this one nests under. When set, the | ||
| * sidebar renders this dashboard indented beneath its parent instead of at | ||
| * the top level. Orphans (parent missing/inaccessible) fall back to the top | ||
| * level. Self-references and cycles are ignored by the renderer. | ||
| */ | ||
| parentId?: string; | ||
|
Comment on lines
+117
to
+123
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🟡 Nested dashboards lose parentId when saved from the dashboard pageThis adds Additional Info |
||
| catalog?: { | ||
| templateId?: string; | ||
| templateVersion?: string; | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| --- | ||
| type: added | ||
| date: 2026-06-27 | ||
| --- | ||
|
|
||
| Dashboards can now nest under a parent in the sidebar via a parentId field |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 Nested dashboard drag ordering uses a different ID order than the rendered list
The sortable list now flattens each parent immediately followed by its children, but
handleDashboardDragEndstill computes indices fromvisibleDashboards, whose order can differ. That mismatch can applyarrayMove()to the wrong positions once a child is visually nested under a parent.Additional Info