Improve mobile navigation chrome and sidebar drawer motion#1613
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Here's a visual recap of what changed:
Open the full interactive recap |
There was a problem hiding this comment.
Builder reviewed your changes — looks good ✅
Review Details
This incremental update remains a low-risk PR focused on mobile navigation polish, with one additional housekeeping change in pnpm-lock.yaml. The user-facing behavior is unchanged from the earlier review intent: Analytics still simplifies its mobile top bar by switching to the page background and removing a decorative chart icon, while Assets, Design, and Slides add a short transform transition to their mobile sidebar drawers. The lockfile delta removes stale importer entries for retired templates that no longer exist in the workspace, which aligns with the current repository layout and does not introduce package or install risk.
I re-reviewed the latest diff directly and ran two independent code-review passes with identical focus areas to reduce position bias. Both came back clean. The touched code paths preserve the existing menu button labeling, drawer open/close state handling, route-change auto-close logic, and md+ breakpoint guards such as md:static, md:translate-x-0, and md:transition-none, so the desktop behavior should remain intact.
Risk assessment: Low.
🧪 Browser testing: Will run after this review (PR touches UI code)
Motivation
Description
templates/analytics/app/components/layout/MobileNav.tsxto remove the app icon and change the top bar background frombg-sidebartobg-background.transition-transform duration-200 ease-outandmd:transition-none) to the mobile drawer container intemplates/assets/app/components/layout/Layout.tsx,templates/design/app/components/layout/Layout.tsx, andtemplates/slides/app/components/layout/Layout.tsxso the drawer slides in/out on mobile.templates/{analytics,assets,design,slides}/changelog/2026-06-27-mobile-navigation-chrome-and-motion.mddescribing the visible mobile navigation polish.oxfmtand committed the changes to the current branch with commit message "Improve mobile navigation chrome".Testing
pnpm oxfmton the modified files and it completed successfully.pnpm --filter ./templates/analytics typecheckbut the check failed to run in this environment because the local Node version isv20.20.2whileagent-nativerequires Node22+, so typechecking did not complete.⠀
🟡 Changes are committed on the current branch; pushing and full typecheck are blocked by the local environment (no
originremote configured and Node 22+ required).Codex Task