Add tests for projections / metadata support#24
Open
iblazhko wants to merge 5 commits intoBullOak:masterfrom
Open
Add tests for projections / metadata support#24iblazhko wants to merge 5 commits intoBullOak:masterfrom
iblazhko wants to merge 5 commits intoBullOak:masterfrom
Conversation
Contributor
Author
Actually, I think session property I think we need two separate properties
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds behavioural tests to make sure BullOak can support projections with links to deleted events, and can support streams soft-deleted from EventStore (as opposed to soft deleted by custom event).
There is one test failure that highlights a problem with BullOak.
IsNewStateasfalseIsNewStateastrueI think semantically these are the same, and BullOak session should report same
IsNewStatevalue (whichever is better by design).Also this PR cleans up unused files - local EvenStore executable is not needed anymore, neither is the
appsettings.jsonfor the integration tests, and there were some leftover.feature.csfiles.