General cleanup

.github/workflows/build-on-push.yml

@@ -12,7 +12,7 @@ jobs:
       - name: Run Tcp ESDB image
         run: docker run -d --name tcp_esdbnode -it -p 2113:2113 -p 1113:1113 eventstore/eventstore:release-5.0.11 --runprojections all --startstandardprojections
       - name: Run Grpc ESDB image
-        run: docker run -d --name grpc_esdbnode -it -p 2114:2113 -p 1114:1113 eventstore/eventstore:22.10.1-bionic --insecure --runprojections all --startstandardprojections
+        run: docker run -d --name grpc_esdbnode -it -p 2114:2113 -p 1114:1113 eventstore/eventstore:22.10.2-bionic --insecure --runprojections all --startstandardprojections --enable-atom-pub-over-http
       - name: Checkout
         uses: actions/checkout@v2
       - name: Setup .NET
@@ -30,4 +30,19 @@ jobs:
       - name: Test
         run: dotnet test --no-build --verbosity minimal
         working-directory: ./src
-
+      - name: Stop Tcp ESDB image
+        if: always()
+        run: |
+          id=$(docker ps -a -q -f name=tcp_esdbnode)
+          if [ ! -z  "$id" ]; then
+            docker stop $id
+            docker rm $id
+          fi
+      - name: Stop Grpc ESDB image
+        if: always()
+        run: |
+          id=$(docker ps -a -q -f name=grpc_esdbnode)
+          if [ ! -z  "$id" ]; then
+            docker stop $id
+            docker rm $id
+          fi

.github/workflows/build-pr.yml

@@ -12,7 +12,7 @@ jobs:
       - name: Run Tcp ESDB image
         run: docker run -d --name tcp_esdbnode -it -p 2113:2113 -p 1113:1113 eventstore/eventstore:release-5.0.11 --runprojections all --startstandardprojections
       - name: Run Grpc ESDB image
-        run: docker run -d --name grpc_esdbnode -it -p 2114:2113 -p 1114:1113 eventstore/eventstore:22.10.1-bionic --insecure --runprojections all --startstandardprojections
+        run: docker run -d --name grpc_esdbnode -it -p 2114:2113 -p 1114:1113 eventstore/eventstore:22.10.2-bionic --insecure --runprojections all --startstandardprojections --enable-atom-pub-over-http
       - uses: actions/checkout@v2
       - name: Setup .NET
         uses: actions/setup-dotnet@v1
@@ -29,5 +29,19 @@ jobs:
       - name: Test
         run: dotnet test --no-build --verbosity minimal
         working-directory: ./src
-
-
+      - name: Stop Tcp ESDB image
+        if: always()
+        run: |
+          id=$(docker ps -a -q -f name=tcp_esdbnode)
+          if [ ! -z  "$id" ]; then
+            docker stop $id
+            docker rm $id
+          fi
+      - name: Stop Grpc ESDB image
+        if: always()
+        run: |
+          id=$(docker ps -a -q -f name=grpc_esdbnode)
+          if [ ! -z  "$id" ]; then
+            docker stop $id
+            docker rm $id
+          fi

.github/workflows/build-version-tag.yml

@@ -47,7 +47,7 @@ jobs:
       - name: Run Tcp ESDB image
         run: docker run -d --name tcp_esdbnode -it -p 2113:2113 -p 1113:1113 eventstore/eventstore:release-5.0.11 --runprojections all --startstandardprojections
       - name: Run Grpc ESDB image
-        run: docker run -d --name grpc_esdbnode -it -p 2114:2113 -p 1114:1113 eventstore/eventstore:22.10.1-bionic --insecure --runprojections all --startstandardprojections
+        run: docker run -d --name grpc_esdbnode -it -p 2114:2113 -p 1114:1113 eventstore/eventstore:22.10.2-bionic --insecure --runprojections all --startstandardprojections --enable-atom-pub-over-http
       - name: Setup .NET
         uses: actions/setup-dotnet@v1
         with:
@@ -68,3 +68,19 @@ jobs:
           nuget_key: ${{ secrets.PUBLISH_BO_EVENTSTORE }}
         run: dotnet nuget push "./BullOak.Repositories.EventStore/bin/Any CPU/release/BullOak.Repositories.EventStore*.nupkg" --api-key "$nuget_key"  -s https://api.nuget.org/v3/index.json --skip-duplicate
         working-directory: ./src
+      - name: Stop Tcp ESDB image
+        if: always()
+        run: |
+          id=$(docker ps -a -q -f name=tcp_esdbnode)
+          if [ ! -z  "$id" ]; then
+            docker stop $id
+            docker rm $id
+          fi
+      - name: Stop Grpc ESDB image
+        if: always()
+        run: |
+          id=$(docker ps -a -q -f name=grpc_esdbnode)
+          if [ ! -z  "$id" ]; then
+            docker stop $id
+            docker rm $id
+          fi

src/BullOak.Repositories.EventStore.Test.Integration/BullOak.Repositories.EventStore.Test.Integration.csproj

@@ -19,7 +19,7 @@
     <PackageReference Include="Grpc.Net.Client" Version="2.53.0" />
     <PackageReference Include="Microsoft.Extensions.Configuration" Version="7.0.0" />
     <PackageReference Include="Microsoft.Extensions.Configuration.Json" Version="7.0.0" />
-    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.6.1" />
+    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.6.2" />
     <PackageReference Include="Newtonsoft.Json" Version="13.0.3" />
     <PackageReference Include="OneOf" Version="3.0.243" />
     <PackageReference Include="Polly" Version="7.2.3" />
@@ -40,13 +40,4 @@
     <ProjectReference Include="..\BullOak.Repositories.EventStore\BullOak.Repositories.EventStore.csproj" />
   </ItemGroup>
 
-  <ItemGroup>
-    <Content Include="appsettings.json">
-      <CopyToOutputDirectory>Always</CopyToOutputDirectory>
-    </Content>
-    <Content Include="EventStoreServer\EventStore.ClusterNode.exe">
-      <CopyToOutputDirectory>Always</CopyToOutputDirectory>
-    </Content>
-  </ItemGroup>
-
 </Project>

src/BullOak.Repositories.EventStore.Test.Integration/Contexts/EventStoreIntegrationContext.cs

@@ -68,7 +68,7 @@ public EventStoreIntegrationContext(PassThroughValidator validator)
             DateTimeProvider = new TestDateTimeProvider();
         }
 
-        public static void SetupNode()
+        public static void SetupConfiguration()
         {
             configuration = Configuration.Begin()
                 .WithDefaultCollection()
@@ -97,10 +97,6 @@ async Task<IStoreEventsToStream> ConfigureWriter()
                 _ => throw new ArgumentOutOfRangeException(nameof(protocol))
             };
 
-        public static void TeardownNode()
-        {
-        }
-
         public async Task<IManageSessionOf<IHoldHigherOrder>> StartSession(string streamName, DateTime? appliesAt = null)
         {
             var session = await Repository.BeginSessionFor(streamName, appliesAt: appliesAt).ConfigureAwait(false);
@@ -150,6 +146,7 @@ private async Task<StoredEvent[]> GrpcReadEventsFromStreamRaw(string id)
         {
             var readResults = connV20.ReadStreamAsync(ClientV20.Direction.Forwards, id, ClientV20.StreamPosition.Start);
             return await readResults
+                        // ReSharper disable once ConditionIsAlwaysTrueOrFalse
                         .Where(e => e.Event != null)
                         .Select(e => e.Event.ToStoredEvent(configuration.StateFactory))
                         .ToArrayAsync();

src/BullOak.Repositories.EventStore.Test.Integration/Specification/ReadModelSpecs.feature

@@ -72,5 +72,5 @@ Scenario Outline: Reconstitute state based on category with two event types up t
 	And after waiting for 15 seconds for categories to be processed
 	When I load all my entities as of '2020-09-20 11:10:00' for the streams category
 	Then the load process should succeed
-    And the visibilty should be disabled
+    And the visibility should be disabled