Exclude i128 and u128 when targeting emscripten#276
Open
Spoonbender wants to merge 4 commits intoBurntSushi:masterfrom
Open
Exclude i128 and u128 when targeting emscripten#276Spoonbender wants to merge 4 commits intoBurntSushi:masterfrom
Spoonbender wants to merge 4 commits intoBurntSushi:masterfrom
Conversation
Getting rid of warnings when compiling for emscripten.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #272
The
i128andu128experimental types are not well supported by emscripten, andranddoesn't support them when targeting emscripten.This PR excludes supports for
i128andu128from quickcheck to properly build when targeting emscripten.(In the future we might encounter other build targets that don't support
i128andi128, and we should be able to exclude from them with little adjustments)Not included in this PR: