Repository navigation
feat(transcode): --target size targeting and Custom size row - #1
Draft
ButtercupRobrts wants to merge 5 commits into
Draft
ButtercupRobrts wants to merge 5 commits into
ButtercupRobrts wants to merge 5 commits into
Conversation
ButtercupRobrts
force-pushed
the
feat/transcode-quality-size-upstream
branch
from
September 27, 2026 16:52
b9535ec to
0886701
Compare
- --target flag + parse_target_size normalization for free-text sizes - plan_target: duration probe, bitrate math, floor-based resolution step-down - transcode_video_target: two-pass encode, pass-scoped toast, one overshoot retry - refusal matrix: conflicts, gif/picture, below-floor, audio-only, >=source, bad probes - pass-aware ffmpeg stub + notification -p/-r id stub in shell harness
- select_quality appends an mp4-gated Custom size… sentinel row last, single-sourced via $custom_label with a mandatory subtext so --default-index 1 and uniform row heights survive - post-strip sentinel branch mints target:<bytes> through the return channel; the tier whitelist keeps rejecting every other foreign label - new prompt_target_size helper wraps parse_target_size in a bounded for-1-2 loop: Esc cancels, empty/unparseable buys one hinted re-prompt - main() unwraps target:<bytes> inside the menu gate into target_bytes/target_token/quality="" -- the planner, output_path, and dispatch are byte-identical to a --target run - plan_target floor case gains the IN-03 *) arm; --target reject loop gains the IN-01 empty-string token - omarchy-menu-input stub (FAKE_INPUT/FAKE_INPUT$n knobs, unset = exit 1 tripwire) ships in the same commit so the suite can never hang on the real binary's done_file spin-wait
--target, size estimates, refusal minimums, and the done notification now all mean 1 MB = 1,000,000 bytes (numfmt --from/--to=si), matching file managers and upload limits like Discord's 25 MB cap. Previously IEC/MiB units made a 400M target budget ~419 MB, so outputs read ~16 MB larger than asked in the Files app. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
ButtercupRobrts
force-pushed
the
feat/transcode-target-size-upstream
branch
from
September 27, 2026 16:52
be3ba95 to
5b6090f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on omacom#12135 (upstream
omacom/omarchy) — will be rebased ontoquattroonce that lands.--target <size>flag for video transcodes: free-text sizes (25M,1.5G,500K,25MB, bare25= MB), decimal units matching file managers and upload limitsmktempdir cleaned via trapCustom size…row on the interactive mp4 quality menu routes through the identical pipeline — interactive runs are argv-identical to--target--target; positional quality +--targetare mutually exclusiveTest plan
test/shell.d/transcode-quality-test.sh— 93/93 (parse matrix, refusal ordering, planner floors, two-pass argv, retry math, sentinel containment)./test/cli— 112/112--targetrefusal path andCustom size…→400Mencode verified in the real menuGenerated with Devin