Skip to content

fix(ui): prevent non-string model formatter crash #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kalinon merged 1 commit into from
Apr 1, 2026
Merged

fix(ui): prevent non-string model formatter crash #78

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion web/src/components/CronJobList.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,10 @@ function formatRelativeTime(timestamp) {

function formatModel(model) {
if (!model) return null;
const modelPart = model.includes('/') ? model.split('/').pop() : model;
const modelValue =
typeof model === 'string' ? model : model?.id || model?.model || model?.name || null;
if (!modelValue || typeof modelValue !== 'string') return null;
const modelPart = modelValue.includes('/') ? modelValue.split('/').pop() : modelValue;
const lower = modelPart.toLowerCase();
if (lower.includes('kimi-k2')) return 'Kimi K2.5';
if (lower.includes('opus-4')) return 'Opus 4';
Expand Down
5 changes: 4 additions & 1 deletion web/src/components/CronRunHistoryPanel.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,10 @@ function formatCost(cost) {

function formatModel(model) {
if (!model) return null;
const part = model.includes('/') ? model.split('/').pop() : model;
const modelValue =
typeof model === 'string' ? model : model?.id || model?.model || model?.name || null;
if (!modelValue || typeof modelValue !== 'string') return null;
const part = modelValue.includes('/') ? modelValue.split('/').pop() : modelValue;
const l = part.toLowerCase();
if (l.includes('kimi-k2')) return 'Kimi K2.5';
if (l.includes('opus-4')) return 'Opus 4';
Expand Down
5 changes: 4 additions & 1 deletion web/src/components/SessionDetailPanel.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -497,7 +497,10 @@ export default function SessionDetailPanel({ isOpen, onClose, session, latestRun

const formatModelName = (model) => {
if (!model) return null;
const modelPart = model.includes('/') ? model.split('/').pop() : model;
const modelValue =
typeof model === 'string' ? model : model?.id || model?.model || model?.name || null;
if (!modelValue || typeof modelValue !== 'string') return null;
const modelPart = modelValue.includes('/') ? modelValue.split('/').pop() : modelValue;
const lower = modelPart.toLowerCase();
if (lower.includes('kimi-k2')) return 'Kimi K2.5';
if (lower.includes('opus-4-6') || lower.includes('opus-4')) return 'Opus 4';
Expand Down
5 changes: 4 additions & 1 deletion web/src/components/SessionRow.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,11 @@ export default function SessionRow({ session, onClick, statusDisplay }) {

const formatModelName = (model) => {
if (!model) return null;
const modelValue =
typeof model === 'string' ? model : model?.id || model?.model || model?.name || null;
if (!modelValue || typeof modelValue !== 'string') return null;
// Handle provider/model format (e.g., "moonshotai/kimi-k2.5")
const modelPart = model.includes('/') ? model.split('/').pop() : model;
const modelPart = modelValue.includes('/') ? modelValue.split('/').pop() : modelValue;
// Simplify known model names
const lower = modelPart.toLowerCase();
if (lower.includes('kimi-k2')) return 'Kimi K2.5';
Expand Down
5 changes: 4 additions & 1 deletion web/src/pages/CronJobs.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,10 @@ function isWithinJustNowWindow(timestamp) {
*/
function formatModel(model) {
if (!model) return null;
const modelPart = model.includes('/') ? model.split('/').pop() : model;
const modelValue =
typeof model === 'string' ? model : model?.id || model?.model || model?.name || null;
if (!modelValue || typeof modelValue !== 'string') return null;
const modelPart = modelValue.includes('/') ? modelValue.split('/').pop() : modelValue;
const lower = modelPart.toLowerCase();
if (lower.includes('kimi-k2')) return 'Kimi K2.5';
if (lower.includes('opus-4')) return 'Opus 4';
Expand Down
5 changes: 4 additions & 1 deletion web/src/pages/Log.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,10 @@ const groupByDay = (logs) => {

function formatModel(model) {
if (!model) return null;
const modelPart = model.includes('/') ? model.split('/').pop() : model;
const modelValue =
typeof model === 'string' ? model : model?.id || model?.model || model?.name || null;
if (!modelValue || typeof modelValue !== 'string') return null;
const modelPart = modelValue.includes('/') ? modelValue.split('/').pop() : modelValue;
const lower = modelPart.toLowerCase();
if (lower.includes('kimi-k2')) return 'Kimi K2.5';
if (lower.includes('opus-4')) return 'Opus 4';
Expand Down
Loading