fix: use PowerShell instead of wslview on WSL#123
Conversation
WSL users reported that wslu's wslview is discontinued and unavailable in some package managers. The regression tests cover the WSL command builder and initially failed because the first generated command was still `wslview`. Build the WSL opener as a PowerShell `Start-Process -FilePath` script argument with the target quoted as data, then retain the xdg-open, gio, gnome-open, and kde-open fallbacks. Update the user-facing docs and keep the WSL command builder testable from host builds without adding dev-dependencies. Co-authored-by: Sebastian Thiel <sebastian.thiel@icloud.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 60eba78db3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Needs an actual WSL test, which I can't currently perform. |
Did a very unscientific test of using |
|
Alright then, let's do it! |
|
And here is the new release: https://github.com/Byron/open-rs/releases/tag/v5.3.6 |
3 participants
Tasks
This section is for Byron only. Models continuing this PR must not add, remove, check, uncheck, rename, or reorder checkboxes here.
Everything below this line was generated by Codex GPT-5.
Created by Codex on behalf of Byron. Byron will review before this is ready to merge.
Summary
wslviewopener with a PowerShellStart-Process -FilePathcommand invocation./mnt/<drive>/...becomes a Windows drive path, while other absolute WSL paths become UNC paths under\\wsl$\<distro>.pathdiffdependency.Issue
Fixes #122.
Reference: #122 (comment)
Validation
cargo testcargo check --target aarch64-unknown-linux-gnu --testscargo clippy --workspace --all-targets -- -D warningscargo +1.82.0 check --testscargo +1.62.0 check --testswas attempted, but dependency resolution selectedlibc v0.2.186, which requires rustc 1.65 before this crate is checked.codex review --commit 827c0e069d6033aa7c265d41b42a968d835ab45dreturned no actionable findings after the review follow-ups.