Repository navigation
chore: drop commitlint length limits - #45
Merged
Merged
Conversation
Header, body, and footer line lengths are no longer enforced. Wrapped prose and long BREAKING CHANGE footers were failing CI without improving the history. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
header-max-length,body-max-line-length, andfooter-max-line-length, which@commitlint/config-conventionalsets to 100 characters.BREAKING CHANGErules still apply.Why
Every open PR (#34 through #44) fails CI at the commit message check, only because some body or footer lines are over 100 characters. Line wrapping doesn't make the history more useful. CI checks out pull requests at their merge ref, so once this lands, re-running those PRs picks up the new config without rewriting their commits.
Test plan
bun x commitlintpasses on the commits that failed CI on feat(runtime)!: report worker callback outcome instead of run state #34 and feat(otel): propagate W3C trace context across runs, effects, worker tasks, and child runs #44bun run fmt:checkMade with Cursor