Refactor dns.lookup and address handling logic#7
Open
C0oki3s wants to merge 1 commit into
Open
Conversation
Updated dns.lookup to return all addresses and adjusted bitwise operations for consistency.
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the DNS resolution fallback mechanism to retrieve all addresses instead of a single address, and fixes bitwise operations to ensure proper unsigned 32-bit integer handling. The changes improve the reliability of address resolution and prevent potential signed integer issues in IPv4 address normalization.
Key changes:
- Modified
dns.lookupto return all addresses (all: true) instead of a single address - Updated address handling logic to iterate through multiple addresses
- Added unsigned right shift (
>>> 0) to bitwise operations to ensure proper 32-bit unsigned integer conversion
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated dns.lookup to return all addresses and adjusted bitwise operations for consistency.