This repository was archived by the owner on Jan 21, 2022. It is now read-only.
Open
Conversation
graju256
approved these changes
Oct 7, 2020
graju256
left a comment
There was a problem hiding this comment.
Changes look good. I assume we've traced out all the instances where MssoContext.clearAccessToken is getting called.
Author
|
Thank you @graju256. I did look at all calls to clearAccessToken but had to make an educated guess of the intention (whether to clear access and refresh or just access). A double check on this would be great. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Calling the
MssoContext.clearAccessTokenmethod clears all keys in the private token storage. If this is done while a valid refresh token is present but a valid ID token is not, the next refresh call, which will default to using the ID token, will fail.Changes
This MR introduces a separate method
clearAccessAndRefreshTokensfor the cases where both token types should be cleared from the private token storage, and changes the current implementation ofclearAccessTokento clear only the access token while leaving the refresh token intact.The logic in
AccessTokenAssertion.findAccessTokenis also updated for the case where the access token has been cleared, but a valid refresh token is available. The library should first try to update with the refresh token before reverting to the ID token.