derive PartialOrd + Ord for SliceWithHeader and StrWithHeader#86
Open
daddinuz wants to merge 3 commits intoCAD97:masterfrom
Open
derive PartialOrd + Ord for SliceWithHeader and StrWithHeader#86daddinuz wants to merge 3 commits intoCAD97:masterfrom
daddinuz wants to merge 3 commits intoCAD97:masterfrom
Conversation
The semantic of PartialOrd/Ord traits for types SliceWithHeader/StrWithHeader is now the same of the tuple `(&Header, &[Item])`
Author
|
I just realized that simply deriving PartialOrd/Ord can lead to some unclear semantics. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi 👋
As per the title, this PR derives
PartialOrdandOrdtraits for
SliceWithHeaderandStrWithHeadertypes.