Eren hf df 28 jun23#82
Open
ebilir wants to merge 33 commits into
Open
Conversation
Issues: - canopy_scale denominator: /(VegK) -> /(VegK*clumping) Beer's law integral requires 1/(k*Omega), not 1/k; de Pury & Farquhar (1997) PCE 20:537; Bonan (2019) Ch.14 Eq.14.6 - Introduce PAR_leaf = PAR*(1-refl)*k*Omega (leaf-level) replacing PAR *= (1-refl)*(1-exp(-k*Omega*L)) (canopy APAR); keeps a2 (RuBP-limited) at leaf level, consistent with a1 (Rubisco-limited) - J uses PAR_leaf instead of canopy APAR; single canopy_scale applied at output Documentation pass (no numerical changes): - Physical constants (rho_air, Cp_air, eps_mol) extracted and named - All magic numbers explained with units and references: 1.6 (H2O/CO2 diffusivity ratio; Jones 1992), 0.02405 (molar volume of air at 20 C; mol->m/s conversion), 1.26 (Priestley-Taylor alpha; Priestley & Taylor 1972), kai1=0.9 / kai2=0.3 (FvCB curvature/quantum yield), 12e-6 (g C per umol CO2), 86400 s/day, 209 mmol/mol O2 - Variable declarations annotated with units and physical meaning - Section headers for FvCB, canopy scaling, Vcmax/Jmax, C3/C4, PM - References: Farquhar et al. 1980, Bernacchi et al. 2001, Leuning 1997, Medlyn et al. 2011, Monteith 1965, Bonan 2019
1623fe7 to
e32f36e
Compare
…max to nudge away from unrealistic LAI ceilings;
… run; + a few other cleanups.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These updates address 4 issues:
At the same time this branch also incorporates updates from others:
5) Adopts Anthony's correction allowing bi-directional flow to contribute to Fin, Fout
6) Adopts Renato's LIU_AN_ET version of the PAR_leaf, canopy scaling
Unique changes (1-4) described below: