Open
Conversation
…retrieve variables that require log scale(and ones that doesn't require, user specifies these variables
…background difference inside the function
shahidzk1
approved these changes
Feb 21, 2022
shahidzk1
left a comment
shahidzk1
left a comment
There was a problem hiding this comment.
In my opinion, "get predictions" should just give predictions. The user should then decide later on whether to use AMS cut on these predictions or not.
…ns result predicted target of the sample with respect to the threshold
…nd train thresholds with respect to AMS
Member
@shahidzk1 I've taken to account your comment and corrected get predictions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.