414 reg ex - Updated reg expression searching, added explicit vs non search feature, cleaned up test and main files #432
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitch-mitchel
requested changes
Jul 6, 2025
Contributor
mitch-mitchel
left a comment
mitch-mitchel
left a comment
There was a problem hiding this comment.
also, tests are not passing, make sure they pass locally
| // Tests for these functions reflect that varname and testValue will be lowercase by the point they reach these functions | ||
|
|
||
| describe('findMacroMatches', function () { | ||
| it.only('returns matches based on A2J Macro Syntax', function () { |
Contributor
There was a problem hiding this comment.
remove .only so other tests can run
| @@ -0,0 +1,166 @@ | |||
| import 'jquery' | |||
Contributor
There was a problem hiding this comment.
see if jquery is required, if not, remove import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regular expression searching has been updated to allow for explicit vs non explicit searching, the test file has passing tests for said functionality. Additionally, findMatches has been separated into three helper functions for cleaner readability and consistency. Both files have been cleaned up and unnecessary comments have been deleted.