Fix Error processing Generic_Case,LDF_GENERIC data in nedss-datareporting-post-processing-service

[ericnagel]

Description

The original ticket reported that LDF data was not flowing into RDB_Modern.LDF_DATA and RDB_Modern.LDF_DATAMART_COLUMN_REF tables, with steps to reproduce.

After multiple attempts following the steps referenced, I could not replicate this error. However while testing, I encountered a different PostProcessingService error: Error processing Generic_Case,LDF_GENERIC data with ids '10009310': DataProcessingException

The error logged in job_flow_log was: Column names in each table must be unique. Column name DATAMART_COLUMN_NM in table #TMP_ALL_GENERIC is specified more than once. That happened because #TMP_ALL_GENERIC was built from A.\* plus B.DATAMART_COLUMN_NM under the same name. this is now explicitly set.

There was also an older secondary defect in the same procedure: the nulling step could call SUBSTRING on an empty string and it was hardcoded to LDF_GENERIC instead of using the target table parameter. These were both corrected.

Related Issue

APP-420: LDF processing failure

Additional Notes

Ignore whitespace changes when reviewing changes; there were a lot of trailing whitespace which does not get cleaned up automatically in the repo.

Checklist

• I have ensured that the pull request is of a manageable size, allowing it to be reviewed within a single session.
• I have reviewed my changes to ensure they are clear, concise, and well-documented.
• I have updated the documentation, if applicable.
• I have added or updated test cases to cover my changes, if applicable.