Remove Batch Id Cleanup Job SQL script and update changelog files#725
Open
Remove Batch Id Cleanup Job SQL script and update changelog files#725
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
db.msdb.changelog-16.1.yaml:1db.rdb_modern.changelog-16.1.yaml:28191007-create_batch_id_cleanup_job-001.sqlwas deleted and its msdb changelog entry was removed.nrt_delete_job_logis now included in the RDB_modern changelog beforesp_batch_id_cleanup_postprocessing, so the procedure's dependency is deployed with the release.splitStatements: falseso Liquibase preserves the SQL file'sIF ... BEGIN ... ENDblock and seed insert as one batch.Related Issue
APP-404: Update scripts for batch ID cleanup job
Additional Notes
Before:
Returned 1 result.
Returned NULL / 715278124
Failed (the table did not exist)
After:
Returned 0 results ✔
Returned 715278124 / 731278181 ✔
Then:
Returned
Execute the stored procedure:
Finally verify a successful log row was written:
Checklist
I have updated the documentation, if applicable.I have added or updated test cases to cover my changes, if applicable.