Skip to content

Move VectorizedRV to pyrenew.randomvariable - #739

Closed
dylanhmorris with Copilot wants to merge 2 commits into
mainfrom
copilot/move-vectorizedrv-to-randomvariable
Closed

dylanhmorris with Copilot wants to merge 2 commits into
mainfrom
copilot/move-vectorizedrv-to-randomvariable

Conversation

Copilot AI commented Mar 9, 2026 •

Copy link
Copy Markdown
Contributor

VectorizedRV was defined in pyrenew/observation/noise.py but belongs in the randomvariable module alongside other RV types.

Changes

  • New pyrenew/randomvariable/vectorizedrv.py — VectorizedRV class moved here from noise.py
  • pyrenew/randomvariable/__init__.py — exports VectorizedRV, enabling:
    from pyrenew.randomvariable import VectorizedRV
  • pyrenew/observation/noise.py — replaces class definition with from pyrenew.randomvariable import VectorizedRV; existing imports via pyrenew.observation remain valid

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • releases.astral.sh
    • Triggering command: /home/REDACTED/.local/bin/uv uv sync -q (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Original prompt

This section details on the original issue you should resolve

<issue_title>Move VectorizedRV to the randomvariable.py module</issue_title>
<issue_description>Not for this PR: move to this to the randomvariable.py module

Originally posted by @dylanhmorris in #644 (comment)
</issue_description>

<agent_instructions>Move the VectorizedRV class to the randomvariable module, and expose it, so that from pyrenew.randomvariable import VectorizedRV is valid.

Add from pyrenew.randomvariable import VectorizedRV to noise.py

Update any existing import statements for VectorizedRV </agent_instructions>

Comments on the Issue (you are @copilot in this section)


🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

Co-authored-by: dylanhmorris <8032117+dylanhmorris@users.noreply.github.com>
Copilot AI changed the title [WIP] Move VectorizedRV to randomvariable module Move VectorizedRV to pyrenew.randomvariable Mar 9, 2026
@github-actions

github-actions Bot commented Mar 9, 2026

Copy link
Copy Markdown

Thank you for your contribution @Copilot 🚀! Your github-pages is ready for download 👉 here 👈!
(The artifact expires on 2026-03-16T23:02:14Z. You can re-generate it by re-running the workflow here.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move VectorizedRV to the randomvariable.py module

2 participants