Skip to content

Update road download function - #432

Open
mcuadera wants to merge 2 commits into
hotfixfrom
426-update-roads-and-cities-rds-names
Open

Update road download function#432
mcuadera wants to merge 2 commits into
hotfixfrom
426-update-roads-and-cities-rds-names

Conversation

@mcuadera

Copy link
Copy Markdown
Collaborator

The rnaturalearth package may fail due to issues with the SSL certificate, especially when behind a firewall. This modifies the update_road_spatial_data() function to take a zip file downloaded from the Natural Earth website. To test:

  1. Find and download the roads zip file here
  2. Pass the local file_path to update_road_spatial_data(). Ensure the output path is in "GID/PEB/SIR/Sandbox/spatial/roads.new.rds".

able to build the roads dataset by downloading the zipfile from Natural Earth directly
@mcuadera mcuadera self-assigned this Mar 23, 2026
@mcuadera mcuadera added the bug Something isn't working label Mar 23, 2026
@mcuadera mcuadera linked an issue Mar 23, 2026 that may be closed by this pull request
@codecov-commenter

codecov-commenter commented Mar 23, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 2.01%. Comparing base (b94a303) to head (a5ccabe).

Files with missing lines Patch % Lines
R/update_spatial_data.R 0.00% 7 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##           hotfix    #432   +/-   ##
======================================
  Coverage    2.01%   2.01%           
======================================
  Files          37      37           
  Lines       14984   14984           
======================================
  Hits          302     302           
  Misses      14682   14682           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛Update roads and cities rds names

2 participants