Skip to content

Fix color palettes - #471

Merged
scarlettlee9 merged 5 commits into
hotfixfrom
470-fix-color-palettes
Aug 11, 2026
Merged

Fix color palettes#471
scarlettlee9 merged 5 commits into
hotfixfrom
470-fix-color-palettes

Conversation

@scarlettlee9

Copy link
Copy Markdown
Collaborator

Fixed color palettes for epicurve, es.detections, cases and para.case to add cVDPV3 and VDPV3. Can test with nigeria desk review.

Closes issue #470

@scarlettlee9
scarlettlee9 requested a review from als329 August 10, 2026 15:16
@codecov-commenter

codecov-commenter commented Aug 10, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 2.02%. Comparing base (9627bf5) to head (424b38e).

Files with missing lines Patch % Lines
R/f.color.schemes.R 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           hotfix    #471      +/-   ##
=========================================
+ Coverage    1.99%   2.02%   +0.03%     
=========================================
  Files          38      38              
  Lines       15166   15173       +7     
=========================================
+ Hits          302     308       +6     
- Misses      14864   14865       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

removing redundancy that was limited to type 3 viruses, updating colors for types 1 and 2 to be consistent across schemes.
als329
als329 previously approved these changes Aug 10, 2026

@als329 als329 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested using Nigeria DR data; filtered afp data to just the 10 rows with cvdpv 3 and vdpv 3 and confirmed all 10 cases appear on the chart. Also ran on the whole data frame and confirmed both categories appear in the legend (but represent small portions of the overall bars that they are not actually visible.

also need to update the test file so it passes the checks. we are learning :)
@als329
als329 dismissed their stale review August 10, 2026 16:14

the checks failed.

removing a hanging comma (:
als329
als329 previously approved these changes Aug 10, 2026

@als329 als329 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@als329
als329 dismissed their stale review August 10, 2026 16:34

one additional comma to remove

@scarlettlee9
scarlettlee9 merged commit b0adf10 into hotfix Aug 11, 2026
5 of 6 checks passed
@scarlettlee9
scarlettlee9 deleted the 470-fix-color-palettes branch August 11, 2026 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants