Moved st_make_valid() to process_spatial() - #295
Open
chadhunt2 wants to merge 2 commits into
Open
Conversation
mcuadera
requested changes
Mar 2, 2026
mcuadera
left a comment
mcuadera
left a comment
Collaborator
There was a problem hiding this comment.
The st_make_valid() are in the wrong part of the function. Please see this PR to see where we should make them valid. Look through the changes in process_spatial().
mcuadera
self-requested a review
March 27, 2026 18:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved st_make_valid() from f.pre.stsample01 to process_spatial() in preprocessing