ci: add job timeout-minutes and fix garbled smoke step name/comment#149
Merged
Merged
Conversation
- Add timeout-minutes: 30 to the test job. The install step pulls
torch + chromadb + sentence-transformers and the RAG smoke starts an
embedded ChromaDB; without a bound, a hung download or wedged service
would idle to GitHub's 6-hour default and waste Actions minutes on
both OS legs of the matrix.
- Fix a garbled prepare-step comment ("RAG wuery emulationinttest").
- Rename the smoke step from "Unit Tests + API integration test / RAG
Query Smoke" to "RAG Query Smoke" — it only runs tests.ci_rag_smoke;
the unit tests + coverage run in the following step. The old name
implied this step ran the unit suite.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NXYYNSfqvBrAgghyNmzbHs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Three small, focused hardening/cleanup changes to
.github/workflows/ci.yml:Add
timeout-minutes: 30to thetestjob. The install step pullstorch+chromadb+sentence-transformers, and the RAG smoke spins up an embedded ChromaDB. Today the job has no time bound, so a hung wheel download or a wedged embedded service would run until GitHub Actions' 6-hour default, burning minutes on both OS legs of the matrix (ubuntu + windows). A 30-minute cap fails fast instead.Fix a garbled prepare-step comment.
# data/corpus/cyclaw_overview.md is committed — RAG wuery emulationinttest indexes it.→ readable English.Rename a misleading step. The step named "Unit Tests + API integration test / RAG Query Smoke (ChromaDB 1.5.6 + BM25 + RRF)" only runs
python -m tests.ci_rag_smoke— the unit tests + coverage run in the next step. Renamed to "RAG Query Smoke (ChromaDB 1.5.6 + BM25 + RRF)" so the step log matches what it actually does.Why it helps
Risk
Low. No change to what the steps execute — only a job-level timeout, a comment, and a display name. YAML validated locally (
yaml.safe_load).🤖 Generated with Claude Code
https://claude.ai/code/session_01NXYYNSfqvBrAgghyNmzbHs
Generated by Claude Code